This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Repository navigation
feat: Improve client settings - #2097
Merged
Merged
Conversation
yirutang
commented
May 1, 2023
Contributor
- Add ExecutorProvider to sample
- Add KeepAlive setting to default set up.
GaoleMeng
reviewed
May 3, 2023
| // https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html | ||
| streamWriter = | ||
| JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create()).build(); | ||
| JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create()) |
Contributor
There was a problem hiding this comment.
our example code create the client by "BigQueryWriteClient.create()" does that means we are not passing any keepalive setting?
Contributor
Author
There was a problem hiding this comment.
I added as a default setting. If I use a new transport in the sample, then the default setting will be overwritten.
I think in most cases, users doesn't need to reset the transport settings, our default is covering all that's needed (being set by Dataflow).
GaoleMeng
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.