Repository navigation
Add Android stlport and default toolchains to BUILD. - #8290
Merged
acozzette merged 1 commit intoOct 13, 2021
Merged
Conversation
dlj-NaN
suggested changes
Mar 9, 2021
dlj-NaN
left a comment
Contributor
There was a problem hiding this comment.
Just a quick request... the toolchain target names are probably a bit opaque to folks not used to working with Android, so just one request...
| ], | ||
| ) | ||
|
|
||
| config_setting( |
Contributor
There was a problem hiding this comment.
Would you mind adding a comment with a link to https://docs.bazel.build/versions/master/android-ndk.html#configuring-the-stl ?
I think it probably makes sense to insert above this config_setting rule, with a note that it applies to several of them.
These are additional possibilities for --crosstool_top for Android NDK compilation. Since the NDK doesn't have -lpthread, getting these flags wrong leads to a linker error. Fixes: 180084220
blueshiftlabs
force-pushed
the
more-android-configs
branch
from
May 13, 2021 06:58
cd38c35 to
a8038c2
Compare
Contributor
Author
|
Done, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are additional possibilities for --crosstool_top for Android NDK
compilation. Since the NDK doesn't have -lpthread, getting these flags
wrong leads to a linker error.
Fixes: 180084220