Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @manueldiaz2006t-blip. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #985 +/- ##
=============================================
- Coverage 81.57% 81.53% -0.04%
+ Complexity 3077 3071 -6
=============================================
Files 129 129
Lines 12267 12253 -14
=============================================
- Hits 10007 9991 -16
- Misses 2260 2262 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@wprashed this ideally gets into the 1.4.0 release, noting that are you able to make updates here from latest code review? |
…global option was toggled off, all features are also toggled off
…o cover new changes
|
@jeffpaul I've taken this one over to get it across the finish line. Quite a bit more was left, mostly a bunch of code (especially tests) that could now be removed. Over to you for a quick test to ensure this functions the way you'd expect |
jeffpaul
left a comment
There was a problem hiding this comment.
Works well (or rather no longer stops things from working I guess), thanks!
develop removed the global Enable AI toggle and its `enableExperiments()` helper (#985), and dropped the call from the sibling ability specs. Do the same here, so the spec runs against develop.
Resolve the one conflict: develop edited tests/e2e/specs/experiments/abilities-explorer.spec.js for #985, while this branch had already split that spec into four files, so it stays deleted. #985 also removed the global "Enable AI" toggle and its e2e helpers. Carry that into this branch's own tests the way #985 did for the other experiments: - Drop AI_WorkspaceTest::test_global_toggle_off_prevents_registration and the "is unreachable when AI is globally off" e2e test, since there is no global switch left to turn off. - Remove the enableExperiments() and disableExperiments() calls from the AI Workspace e2e specs, keeping the per-experiment enable and disable. - Stop setting the no longer registered wpai_features_enabled option in AI_WorkspaceTest, the Abilities Explorer controller test and the Explorer's e2e setup. - Name the enableExperiment() helper in the docs instead of the removed enableExperiments(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@manueldiaz2006t-blip if you can connect your GitHub and WPORG accounts then I can ensure your work is properly credited in this AI plugin release. |
develop removed the global Enable AI toggle and its `enableExperiments()` helper (#985), and dropped the call from the sibling ability specs. Do the same here, so the spec runs against develop.
develop removed the global Enable AI toggle and its `enableExperiments()` helper (#985), and dropped the call from the sibling ability specs. Do the same here, so the spec runs against develop.
What?
Closes #600
Removes the
Enable AIheader toggle from the AI settings page (routes/ai-home/stage.tsx), cleans up remainingglobalEnabledUI disabling logic, and allows individual feature and experiment group toggles to directly control plugin functionality.Why?
The
Enable AIheader toggle displayed a binary ON/OFF state that did not accurately reflect individual feature configurations. Per maintainer consensus in #600, this PR removes the global header toggle entirely, allowing individual feature toggles and category group toggles (or deactivating the plugin / using core filters) to manage functionality.How?
Enable AIheader<ToggleControl>andInfoTipfromroutes/ai-home/stage.tsx.globalToggleDescription,GLOBAL_FIELD_ID,noop, andDisabledTogglecomponent fromstage.tsx.globalEnabledprop and conditions fromSectionActionsandVisualCardToggleinstage.tsx, ensuring individual toggles and bulk action buttons remain interactive..ai-showcase-card--disabledCSS rule fromroutes/ai-home/style.scss.is_globally_enabled()inincludes/Abstracts/Abstract_Feature.phpto default totruewhen option is not explicitly set.tests/e2e/utils/helpers.ts) indisableExperimentsandenableExperimentsto wait for section action buttons to render before counting, correctly capture settings save responses, and toggle showcase cards.tests/e2e/specs/admin/settings.spec.jsto assert section button states and removed the obsolete test for disabled global bulk actions.Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity
Model(s): Gemini 2.5 Pro
Used for: Diagnosing E2E test failures, updating settings UI components and E2E test assertions, and structuring the PR according to repository guidelines.
Testing Instructions
options-general.php?page=ai-wp-admin).Enable AIheader toggle.npm run typecheck,npm run lint:js, andnpm run buildpass without errors.Screenshots or screencast
Changelog Entry