Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update output buffering setting description
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
  • Loading branch information
westonruter and felixarntz authored Aug 17, 2023
commit 68d7983af775d803bc3693f65549c513951d28dc
2 changes: 1 addition & 1 deletion admin/server-timing.php
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ function perflab_render_server_timing_page_output_buffer_checkbox() {
?>
Comment thread
felixarntz marked this conversation as resolved.
Outdated
<?php endif; ?>
<?php endif; ?>
<?php esc_html_e( 'This is needed to capture metrics after headers have been sent and the template is being rendered. Without output buffering, adding a hook that fires during template rendering may result in a PHP notice: "Function Perflab_Server_Timing::register_metric was called incorrectly. The method must be called before or during the perflab_server_timing_send_header action." Note that output buffering may possibly cause an increase in TTFB if the response would be flushed multiple times.', 'performance-lab' ); ?>
<?php esc_html_e( 'This is needed to capture metrics after headers have been sent and while the template is being rendered. Note that output buffering may possibly cause an increase in TTFB if the response would be flushed multiple times.', 'performance-lab' ); ?>
Comment thread
felixarntz marked this conversation as resolved.
Outdated
Comment thread
westonruter marked this conversation as resolved.
Outdated
</p>
</fieldset>
<?php
Expand Down