Skip to content

Storage: Add client_options to constructors for manual clients. - #9054

Merged
busunkim96 merged 3 commits into
googleapis:masterfrom
MaxxleLLC:add-client_options-to-storage
Aug 28, 2019
Merged

busunkim96 merged 3 commits into
googleapis:masterfrom
MaxxleLLC:add-client_options-to-storage

Conversation

@emar-kar

Copy link
Copy Markdown
Contributor

Toward #8475

Applying requested chgs.
* added new test to check 'client_options' as a dict
* deleted extra asserts
* chged couple of objects to an alternative value
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
@IlyaFaer IlyaFaer added kokoro:force-run Add this label to force Kokoro to re-run the tests. api: storage Issues related to the Cloud Storage API. labels Aug 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@emar-kar
emar-kar marked this pull request as ready for review August 19, 2019 12:09
@busunkim96
busunkim96 merged commit 245ffad into googleapis:master Aug 28, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@emar-kar
emar-kar deleted the add-client_options-to-storage branch September 3, 2019 07:35
emar-kar added a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@tseaver tseaver mentioned this pull request Oct 10, 2019
31 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants